rename erase_regions to erase_and_anonymize_regions #145717
Conversation
rustbot
added
A-LLVM
|
HIR ty lowering was modified cc @fmease Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in match checking cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred to the CTFE machinery |
This comment has been minimized.
This comment has been minimized.
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
BoxyUwU
force-pushed
the
erase_regions_rename
branch
from
1c18aa3 to
1347fee
Compare
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
erase_regions_rename
branch
2 times, most recently
from
14233ac to
300c85e
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors r=lcnr rollup=never |
bors
added
S-waiting-on-bors
rename erase_regions to erase_and_anonymize_regions I find it consistently confusing that `erase_regions` does more than replacing regions with `'erased`. it also makes some code look real goofy to be writing manual folders to erase regions with a comment saying "we cant use erase regions" :> or code that re-calls erase_regions on types with regions already erased just to anonymize all the bound regions. r? lcnr idk how i feel about the name being almost twice as long now
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #145711) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
Merge conflicts. |
|
:( |
lcnr
force-pushed
the
erase_regions_rename
branch
from
300c85e to
8cde544
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=lcnr rollup=iffy |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing be8de5d (parent) -> 364da5d (this PR) Test differencesShow 8 test diffs8 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 364da5d88d772fa40fb20353443595385443ac25 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (364da5d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 467.841s -> 468.052s (0.05%) |
rename erase_regions to erase_and_anonymize_regions I find it consistently confusing that `erase_regions` does more than replacing regions with `'erased`. it also makes some code look real goofy to be writing manual folders to erase regions with a comment saying "we cant use erase regions" :> or code that re-calls erase_regions on types with regions already erased just to anonymize all the bound regions. r? lcnr idk how i feel about the name being almost twice as long now
Relevant upstream PR: - rust-lang/rust#145717 (rename erase_regions to erase_and_anonymize_regions) Resolves: model-checking#4353
Relevant upstream PR: - rust-lang/rust#145717 (rename erase_regions to erase_and_anonymize_regions) Resolves: #4353 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
I find it consistently confusing that
erase_regionsdoes more than replacing regions with'erased. it also makes some code look real goofy to be writing manual folders to erase regions with a comment saying "we cant use erase regions" :> or code that re-calls erase_regions on types with regions already erased just to anonymize all the bound regions.r? lcnr
idk how i feel about the name being almost twice as long now